Use wildcard_url for url naming

Prevent the creation of multiple pages with the same wildcard_url under the same parent page. Alchemy will validate the slug and will prevent creating the same slug twice.

Author: kulturbande

app/models/alchemy/page/page_naming.rb

@@ -67,15 +67,20 @@ def set_urlname
       end
 
       # Returns the full nested urlname.
-      #
+      # Uses the wildcard_url pattern from the page definition if present,
+      # otherwise converts the slug or name to a url-friendly string.
       def nested_url_name
-        converted_url_name = convert_to_urlname(slug.blank? ? name : slug)
+        url_part = wildcard_url&.pattern || convert_to_urlname(slug.blank? ? name : slug)
         if parent&.language_root?
-          converted_url_name
+          url_part
         else
-          [parent&.urlname, converted_url_name].compact.join("/")
+          [parent&.urlname, url_part].compact.join("/")
         end
       end
+
+      def wildcard_url
+        @_wildcard_url ||= PageDefinition.get(page_layout)&.wildcard_url
+      end
     end
   end
 end

spec/models/alchemy/page_spec.rb

@@ -1860,6 +1860,27 @@ module Alchemy
         end
       end
 
+      context "with a page layout that has a wildcard_url" do
+        let(:parent) { create(:alchemy_page, name: "Products") }
+        let(:pattern_page) { create(:alchemy_page, parent: parent, name: "Product Details", page_layout: "product_detail") }
+
+        it "uses the wildcard_url pattern instead of the page name" do
+          expect(pattern_page.urlname).to eq("products/:id")
+        end
+
+        it "uses the wildcard_url pattern as slug" do
+          expect(pattern_page.slug).to eq(":id")
+        end
+
+        context "with a child page under a wildcard_url page" do
+          let(:child) { create(:alchemy_page, parent: pattern_page, name: "Comments") }
+
+          it "includes the parent's wildcard_url pattern in the path" do
+            expect(child.urlname).to eq("products/:id/comments")
+          end
+        end
+      end
+
       context "if new urlname exists as a legacy url" do
         it "will delete obsolete legacy_urls" do
           expect(page.urlname).to eq("parentparent/parent/page")