Use url_pattern as page slug

Instead of the name the url_pattern will be used during the creation of the page. This looks better and is indicating the special status of that page.

Author: kulturbande

app/models/alchemy/page/page_naming.rb

@@ -67,15 +67,20 @@ def set_urlname
       end
 
       # Returns the full nested urlname.
-      #
+      # Uses the url_pattern from the page definition if present,
+      # otherwise converts the slug or name to a url-friendly string.
       def nested_url_name
-        converted_url_name = convert_to_urlname(slug.blank? ? name : slug)
+        url_part = page_layout_url_pattern || convert_to_urlname(slug.blank? ? name : slug)
         if parent&.language_root?
-          converted_url_name
+          url_part
         else
-          [parent&.urlname, converted_url_name].compact.join("/")
+          [parent&.urlname, url_part].compact.join("/")
         end
       end
+
+      def page_layout_url_pattern
+        @_page_layout_url_pattern ||= PageDefinition.get(page_layout)&.url_pattern
+      end
     end
   end
 end

spec/models/alchemy/page_spec.rb

@@ -1860,6 +1860,27 @@ module Alchemy
         end
       end
 
+      context "with a page layout that has a url_pattern" do
+        let(:parent) { create(:alchemy_page, name: "Products") }
+        let(:pattern_page) { create(:alchemy_page, parent: parent, name: "Product Details", page_layout: "product_detail") }
+
+        it "uses the url_pattern instead of the page name" do
+          expect(pattern_page.urlname).to eq("products/:id")
+        end
+
+        it "uses the url_pattern as slug" do
+          expect(pattern_page.slug).to eq(":id")
+        end
+
+        context "with a child page under a pattern page" do
+          let(:child) { create(:alchemy_page, parent: pattern_page, name: "Comments") }
+
+          it "includes the parent's url_pattern in the path" do
+            expect(child.urlname).to eq("products/:id/comments")
+          end
+        end
+      end
+
       context "if new urlname exists as a legacy url" do
         it "will delete obsolete legacy_urls" do
           expect(page.urlname).to eq("parentparent/parent/page")

spec/services/alchemy/url_pattern_matcher_spec.rb

@@ -105,15 +105,6 @@ def create_page(name:, layout: "standard", parent: language_root)
       end
     end
 
-    context "with two unconstrained sibling pages of the same layout" do
-      let!(:second_product_by_slug_page) { create_page(name: "Second Product By Slug", layout: "product_by_slug", parent: products_page) }
-
-      it "matches the first sibling returned by the database" do
-        matcher = described_class.new("products/widget")
-        expect(matcher.page).to eq(product_by_slug_page)
-      end
-    end
-
     context "with competing sibling patterns of different segment counts" do
       let!(:shared_page) { create_page(name: "Shared") }
       let!(:multi_segment_page) { create_page(name: "Multi Segment", layout: "blog_post", parent: shared_page) }