Skip to content

Commit 5fcb9c4

Browse files
committed
Do not store screensize at login
This feature has been deprecated in Alchemy 4.2
1 parent a076dc5 commit 5fcb9c4

3 files changed

Lines changed: 0 additions & 14 deletions

File tree

app/controllers/alchemy/user_sessions_controller.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ def create
2020
authenticate_user!
2121

2222
if user_signed_in?
23-
store_screen_size
2423
if session[:redirect_path].blank?
2524
redirect_path = admin_dashboard_path
2625
else
@@ -49,10 +48,6 @@ def check_user_count
4948
end
5049
end
5150

52-
def store_screen_size
53-
session[:screen_size] = params[:user_screensize]
54-
end
55-
5651
# Overwriting the default of Devise
5752
def after_sign_out_path_for(resource_or_scope)
5853
if request.referer.blank? || request.referer.to_s =~ /admin/

app/views/alchemy/user_sessions/new.html.erb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
</small>
1010
</div>
1111
<div class="submit">
12-
<%= hidden_field_tag 'user_screensize' %>
1312
<button class="secondary"><%= Alchemy.t(:login) %></button>
1413
</div>
1514
<% end %>
@@ -19,9 +18,6 @@
1918
<script type="text/javascript" charset="utf-8">
2019
jQuery(function($) {
2120
$('#user_login').focus();
22-
$('#user_screensize').val(function() {
23-
return screen.width+'x'+screen.height;
24-
});
2521
});
2622
</script>
2723
<%- end -%>

spec/controllers/user_sessions_controller_spec.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,6 @@
5454
end
5555
end
5656

57-
it "stores users screen size" do
58-
post :create, params: {user: user_params, user_screensize: screen_size}
59-
expect(session[:screen_size]).to eq(screen_size)
60-
end
61-
6257
context 'without valid params' do
6358
it "renders login form" do
6459
post :create, params: {user: {login: ''}}

0 commit comments

Comments
 (0)