Merge pull request #17 from johnny-bit/data_early_bail

lifeofguenter · lifeofguenter · commit 63b82fcad6fb · 2015-11-30T17:18:22.000+02:00
Instead of early bailout, try to process all possible response nodes.… thx @johnny-bit
diff --git a/src/AfriCC/EPP/Frame/Response.php b/src/AfriCC/EPP/Frame/Response.php
@@ -84,11 +84,11 @@ public function data()
     {
         $nodes = $this->get('//epp:epp/epp:response/epp:resData');
         if ($nodes === false || !($nodes instanceof DOMNodeList) || $nodes->length === 0 || !$nodes->item(0)->hasChildNodes()) {
-            return;
+            $data = [];
+        } else {
+            $data = $this->nodeToArray($nodes->item(0));
         }
 
-        $data = $this->nodeToArray($nodes->item(0));
-
         // check for extension data
         $nodes = $this->get('//epp:epp/epp:response/epp:extension');
         if ($nodes !== false && $nodes instanceof DOMNodeList && $nodes->length > 0 && $nodes->item(0)->hasChildNodes()) {

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,11 @@ public function data()`
`84`	`84`	`{`
`85`	`85`	`$nodes = $this->get('//epp:epp/epp:response/epp:resData');`
`86`	`86`	`if ($nodes === false \|\| !($nodes instanceof DOMNodeList) \|\| $nodes->length === 0 \|\| !$nodes->item(0)->hasChildNodes()) {`
`87`		`- return;`
	`87`	`+ $data = [];`
	`88`	`+ } else {`
	`89`	`+ $data = $this->nodeToArray($nodes->item(0));`
`88`	`90`	`}`
`89`	`91`
`90`		`- $data = $this->nodeToArray($nodes->item(0));`
`91`		`-`
`92`	`92`	`// check for extension data`
`93`	`93`	`$nodes = $this->get('//epp:epp/epp:response/epp:extension');`
`94`	`94`	`if ($nodes !== false && $nodes instanceof DOMNodeList && $nodes->length > 0 && $nodes->item(0)->hasChildNodes()) {`