diff --git a/src/pages/ContributorProfilePage.test.jsx b/src/pages/ContributorProfilePage.test.jsx
new file mode 100644
index 0000000..d25e31f
--- /dev/null
+++ b/src/pages/ContributorProfilePage.test.jsx
@@ -0,0 +1,234 @@
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
+import { render, screen, waitFor } from '@testing-library/react'
+import { MemoryRouter, Routes, Route } from 'react-router-dom'
+import ContributorProfilePage from './ContributorProfilePage'
+
+const app = vi.hoisted(() => ({
+ state: {
+ orgs: [{ login: 'AOSSIE-Org' }],
+ pat: '',
+ pullsData: {},
+ model: {
+ contributors: [{ login: 'testuser', orgs: ['AOSSIE-Org'] }],
+ },
+ },
+}))
+
+vi.mock('../context/AppContext', () => ({ useApp: () => app.state }))
+
+vi.mock('recharts', () => ({
+ ResponsiveContainer: ({ children }) =>
{children}
,
+ BarChart: ({ children }) =>
{children}
,
+ Bar: () => null,
+ XAxis: () => null,
+ YAxis: () => null,
+ CartesianGrid: () => null,
+ Tooltip: () => null,
+}))
+
+function renderPage(username = 'testuser') {
+ return render(
+
+
+ } />
+
+
+ )
+}
+
+describe('ContributorProfilePage', () => {
+ beforeEach(() => {
+ vi.restoreAllMocks()
+ app.state = {
+ orgs: [{ login: 'AOSSIE-Org' }],
+ pat: '',
+ pullsData: {},
+ model: {
+ contributors: [{ login: 'testuser', orgs: ['AOSSIE-Org'] }],
+ },
+ }
+ })
+
+ afterEach(() => {
+ vi.clearAllMocks()
+ })
+
+ it('shows error immediately for invalid username without making network calls', async () => {
+ const fetchSpy = vi.spyOn(globalThis, 'fetch')
+
+ renderPage('undefined')
+
+ expect(await screen.findByText('Invalid contributor username.')).toBeInTheDocument()
+ expect(fetchSpy).not.toHaveBeenCalled()
+ })
+
+ it('queries organizations individually to avoid multi-org search 422 errors', async () => {
+ app.state.orgs = [{ login: 'OrgA' }, { login: 'OrgB' }]
+ app.state.model.contributors = [{ login: 'testuser', orgs: ['OrgA', 'OrgB'] }]
+
+ const fetchUrls = []
+ vi.spyOn(globalThis, 'fetch').mockImplementation(async (url) => {
+ fetchUrls.push(url.toString())
+ return {
+ ok: true,
+ status: 200,
+ headers: new Headers(),
+ json: async () => ({ items: [] }),
+ }
+ })
+
+ renderPage('testuser')
+
+ await waitFor(() => {
+ expect(fetchUrls.length).toBe(4) // Exactly 2 calls per org (issues + merged PRs)
+ })
+
+ const orgAIssues = fetchUrls.filter(u => u.includes('author:testuser+org:OrgA') && !u.includes('is:merged'))
+ const orgAMerged = fetchUrls.filter(u => u.includes('author:testuser+is:pr+is:merged+org:OrgA'))
+ const orgBIssues = fetchUrls.filter(u => u.includes('author:testuser+org:OrgB') && !u.includes('is:merged'))
+ const orgBMerged = fetchUrls.filter(u => u.includes('author:testuser+is:pr+is:merged+org:OrgB'))
+
+ expect(orgAIssues).toHaveLength(1)
+ expect(orgAMerged).toHaveLength(1)
+ expect(orgBIssues).toHaveLength(1)
+ expect(orgBMerged).toHaveLength(1)
+ expect(fetchUrls.some(u => u.includes('org:OrgA+org:OrgB'))).toBe(false)
+ })
+
+ it('surfaces specific error message from GitHub API response when 422 occurs', async () => {
+ vi.spyOn(globalThis, 'fetch').mockImplementation(async () => {
+ return {
+ ok: false,
+ status: 422,
+ headers: new Headers(),
+ json: async () => ({
+ message: 'Validation Failed',
+ errors: [{ message: 'The listed users and repositories cannot be searched.' }],
+ }),
+ }
+ })
+
+ renderPage('testuser')
+
+ expect(
+ await screen.findByText(/The listed users and repositories cannot be searched/i)
+ ).toBeInTheDocument()
+ })
+
+ it('retains authored contributions when merged-PR query fails', async () => {
+ app.state.orgs = [{ login: 'OrgA' }]
+ app.state.model.contributors = [{ login: 'testuser', orgs: ['OrgA'] }]
+
+ vi.spyOn(globalThis, 'fetch').mockImplementation(async (url) => {
+ const urlStr = url.toString()
+ if (urlStr.includes('is:merged')) {
+ return {
+ ok: false,
+ status: 500,
+ headers: new Headers(),
+ json: async () => ({ message: 'Server error on merged query' }),
+ }
+ }
+ return {
+ ok: true,
+ status: 200,
+ headers: new Headers(),
+ json: async () => ({
+ items: [{
+ id: 101,
+ number: 1,
+ title: 'Sample Issue',
+ state: 'open',
+ pull_request: {},
+ created_at: new Date().toISOString(),
+ repository_url: 'https://api.github.com/repos/OrgA/repo1',
+ html_url: 'https://github.com/OrgA/repo1/pull/1',
+ }],
+ }),
+ }
+ })
+
+ renderPage('testuser')
+
+ expect(await screen.findByText(/Sample Issue/i)).toBeInTheDocument()
+ expect(await screen.findByText(/merged PR status incomplete/i)).toBeInTheDocument()
+ })
+
+ it('renders partial failure warning when one organization fails and another succeeds', async () => {
+ app.state.orgs = [{ login: 'OrgA' }, { login: 'OrgB' }]
+ app.state.model.contributors = [{ login: 'testuser', orgs: ['OrgA', 'OrgB'] }]
+
+ vi.spyOn(globalThis, 'fetch').mockImplementation(async (url) => {
+ const urlStr = url.toString()
+ if (urlStr.includes('org:OrgB')) {
+ return {
+ ok: false,
+ status: 404,
+ headers: new Headers(),
+ json: async () => ({ message: 'OrgB not found' }),
+ }
+ }
+ return {
+ ok: true,
+ status: 200,
+ headers: new Headers(),
+ json: async () => ({
+ items: [{
+ id: 202,
+ number: 2,
+ title: 'OrgA PR',
+ state: 'open',
+ pull_request: {},
+ created_at: new Date().toISOString(),
+ repository_url: 'https://api.github.com/repos/OrgA/repo1',
+ html_url: 'https://github.com/OrgA/repo1/pull/2',
+ }],
+ }),
+ }
+ })
+
+ renderPage('testuser')
+
+ expect(await screen.findByText(/OrgA PR/i)).toBeInTheDocument()
+ expect(await screen.findByText(/Partial results loaded.*OrgB/i)).toBeInTheDocument()
+ })
+
+ it('renders rate limit guidance in partial failure warning when one organization is rate limited', async () => {
+ app.state.orgs = [{ login: 'OrgA' }, { login: 'OrgB' }]
+ app.state.model.contributors = [{ login: 'testuser', orgs: ['OrgA', 'OrgB'] }]
+
+ vi.spyOn(globalThis, 'fetch').mockImplementation(async (url) => {
+ const urlStr = url.toString()
+ if (urlStr.includes('org:OrgB')) {
+ return {
+ ok: false,
+ status: 403,
+ headers: new Headers({ 'x-ratelimit-remaining': '0' }),
+ json: async () => ({ message: 'API rate limit exceeded' }),
+ }
+ }
+ return {
+ ok: true,
+ status: 200,
+ headers: new Headers(),
+ json: async () => ({
+ items: [{
+ id: 202,
+ number: 2,
+ title: 'OrgA PR',
+ state: 'open',
+ pull_request: {},
+ created_at: new Date().toISOString(),
+ repository_url: 'https://api.github.com/repos/OrgA/repo1',
+ html_url: 'https://github.com/OrgA/repo1/pull/2',
+ }],
+ }),
+ }
+ })
+
+ renderPage('testuser')
+
+ expect(await screen.findByText(/OrgA PR/i)).toBeInTheDocument()
+ expect(await screen.findByText(/OrgB: rate limit reached/i)).toBeInTheDocument()
+ })
+})
diff --git a/src/pages/SettingsPage.test.jsx b/src/pages/SettingsPage.test.jsx
index f2aa028..12da2b8 100644
--- a/src/pages/SettingsPage.test.jsx
+++ b/src/pages/SettingsPage.test.jsx
@@ -40,6 +40,17 @@ describe('SettingsPage', () => {
expect(await screen.findByRole('button', { name: /cleared/i })).toBeInTheDocument()
})
+ it('does not clear cache or analysis when confirmation is declined', async () => {
+ vi.spyOn(window, 'confirm').mockReturnValue(false)
+
+ render(
)
+
+ await userEvent.click(screen.getByRole('button', { name: /clear all/i }))
+
+ expect(cacheClear).not.toHaveBeenCalled()
+ expect(clearAnalysis).not.toHaveBeenCalled()
+ })
+
it('does not report success when the analysis cache fails to clear', async () => {
cacheClear.mockResolvedValue(true)
clearAnalysis.mockResolvedValue(false)
diff --git a/src/services/analytics.buildAnalyticalModel.test.js b/src/services/analytics.buildAnalyticalModel.test.js
index 85cb58a..ea12d18 100644
--- a/src/services/analytics.buildAnalyticalModel.test.js
+++ b/src/services/analytics.buildAnalyticalModel.test.js
@@ -162,4 +162,27 @@ describe('buildAnalyticalModel', () => {
expect(result.totalRepos).toEqual([])
expect(result.contributors).toEqual([])
})
+
+ it('filters out anonymous contributors or entries without a login', () => {
+ const orgs = [{ login: 'org-a' }]
+ const repoA = makeRepo('repo-a')
+ const reposPerOrg = { 'org-a': [repoA] }
+ const totalReposPerOrg = { 'org-a': [repoA] }
+ const contribsPerRepo = {
+ 'org-a/repo-a': [
+ { login: 'valid-user', avatar_url: '', contributions: 10 },
+ { name: 'Anonymous', contributions: 5 },
+ null,
+ ],
+ }
+
+ const result = buildAnalyticalModel(orgs, reposPerOrg, contribsPerRepo, totalReposPerOrg)
+
+ expect(result.contributors).toHaveLength(1)
+ expect(result.contributors[0].login).toBe('valid-user')
+ expect(result.contributors.some(c => c.login === undefined)).toBe(false)
+ expect(result.totalRepos[0].contributors).toHaveLength(1)
+ expect(result.totalRepos[0].contributors[0].login).toBe('valid-user')
+ expect(result.totalRepos[0].busFactor.factor).toBe(1)
+ })
})
diff --git a/src/services/analytics.js b/src/services/analytics.js
index 8546455..9c91018 100644
--- a/src/services/analytics.js
+++ b/src/services/analytics.js
@@ -20,19 +20,20 @@ export function computeActivityClassification(repo) {
// Bus Factor
export function computeBusFactor(contributors = []) {
- if (!contributors.length) return { factor: 0, risk: 'unknown' }
- const getCount = c => c.contributions ?? c.totalContribs ?? 0
- const total = contributors.reduce((s, c) => s + getCount(c), 0)
+ const valid = (contributors || []).filter(c => c && typeof c === 'object')
+ if (!valid.length) return { factor: 0, risk: 'unknown' }
+ const getCount = c => c?.contributions ?? c?.totalContribs ?? 0
+ const total = valid.reduce((s, c) => s + getCount(c), 0)
if (!total) return { factor: 0, risk: 'unknown' }
let cum = 0
- for (let i = 0; i < contributors.length; i++) {
- cum += getCount(contributors[i])
+ for (let i = 0; i < valid.length; i++) {
+ cum += getCount(valid[i])
if (cum / total > 0.5) {
const f = i + 1
return { factor: f, risk: f <= 1 ? 'critical' : f <= 2 ? 'high' : 'healthy' }
}
}
- return { factor: contributors.length, risk: 'healthy' }
+ return { factor: valid.length, risk: 'healthy' }
}
// Unified Analytical Data Model
@@ -49,7 +50,8 @@ export function buildAnalyticalModel(orgs, reposPerOrg, contribsPerRepo, totalRe
total.forEach(repo => {
const key = `${org.login}/${repo.name}`
- const contribs = contribsPerRepo[key] || []
+ const rawContribs = contribsPerRepo[key] || []
+ const contribs = rawContribs.filter(c => c && typeof c === 'object' && c.login)
const health = computeHealthScore(repo, contribs.length)
const activityClassification = computeActivityClassification(repo)
const bf = computeBusFactor(contribs)
@@ -63,6 +65,7 @@ export function buildAnalyticalModel(orgs, reposPerOrg, contribsPerRepo, totalRe
// Build contributor map — deduplicated by login across orgs
contribs.forEach(c => {
+ if (!c || !c.login) return
if (!contributorMap[c.login]) {
contributorMap[c.login] = {
login: c.login,