Return: Smart Pulldown [1/2]

Adds the ability to directly open the QS panel when there are
no notifications present in the notification panel.
This commit combines the enhancement by HardCorePawn for detectin
notification types for the same.

Credits: kufikugel, HardCorePawn

PS 2-4 : Cleanup

Change-Id: Idf7076eff47a9b02659e1e98e60fa474b3e7cbeb

Author: mnazzzim

core/java/android/provider/Settings.java

@@ -3329,6 +3329,13 @@ public static void setShowGTalkServiceStatusForUser(ContentResolver cr, boolean
          */
         public static final String QS_COLLAPSE_PANEL = "qs_collapse_panel";
 
+        /**
+         * Quick Settings Smart Pulldown
+         *
+         * @hide
+         */
+        public static final String QS_SMART_PULLDOWN = "qs_smart_pulldown";
+
         /**
          * Quick Settings Quick access ribbon
          *

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java

@@ -167,13 +167,21 @@ public boolean onTouchEvent(MotionEvent event) {
 		                mGestureStartY > getHeight() - mHandleBarHeight - getPaddingBottom();
                     }
                     mOkToFlip = getExpandedHeight() == 0;
-                    if (event.getX(0) > getWidth() * (1.0f - STATUS_BAR_SETTINGS_RIGHT_PERCENTAGE) &&
-                            Settings.System.getIntForUser(getContext().getContentResolver(),
-                                    Settings.System.QS_QUICK_PULLDOWN, 0, UserHandle.USER_CURRENT) == 1) {
+                    int quickPulldownMode = Settings.System.getIntForUser(
+                            getContext().getContentResolver(), Settings.System.QS_QUICK_PULLDOWN,
+                            0, UserHandle.USER_CURRENT);
+                    int smartPulldownMode = Settings.System.getIntForUser(
+                            getContext().getContentResolver(), Settings.System.QS_SMART_PULLDOWN,
+                            0, UserHandle.USER_CURRENT);
+                    if (smartPulldownMode == 1 && !mStatusBar.hasClearableNotifications()) {
                         flip = true;
-                    } else if (event.getX(0) < getWidth() * (1.0f - STATUS_BAR_SETTINGS_LEFT_PERCENTAGE) &&
-                            Settings.System.getIntForUser(getContext().getContentResolver(),
-                                    Settings.System.QS_QUICK_PULLDOWN, 0, UserHandle.USER_CURRENT) == 2) {
+                    } else if (smartPulldownMode == 2 && !mStatusBar.hasVisibleNotifications()) {
+                        flip = true;
+                    } else if (quickPulldownMode == 1
+                            && mGestureStartX > getWidth() * (1.0f - STATUS_BAR_SETTINGS_RIGHT_PERCENTAGE)) {
+                        flip = true;
+                    } else if (quickPulldownMode == 2
+                            && mGestureStartX < getWidth() * (1.0f - STATUS_BAR_SETTINGS_LEFT_PERCENTAGE)) {
                         flip = true;
                     }
                     break;

packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java

@@ -1934,11 +1934,19 @@ public void onAnimationEnd(Animator animation) {
         }
     }
 
+    protected boolean hasVisibleNotifications() {
+        return mNotificationData.hasVisibleItems();
+    }
+
+    protected boolean hasClearableNotifications() {
+        return mNotificationData.hasClearableItems();
+    }
+
     @Override
     protected void setAreThereNotifications() {
         final boolean any = mNotificationData.size() > 0;
 
-        final boolean clearable = any && mNotificationData.hasClearableItems();
+        final boolean clearable = any && hasClearableNotifications();
 
         if (SPEW) {
             Log.d(TAG, "setAreThereNotifications: N=" + mNotificationData.size()