HeadsUp: Correctly add and remove the window

isAttachedToWindow() basically works to determine if the view was attached or not.

But on the boot up process when already addHeadsUpView is called but the system is not
fully up and a recreation happens (eg on TRDS...due that the UIModeManager is doing its work as soon as system is ready)
the view gets attached....but not removed on the recreation due that at this time isAttachedToWindow() will return false even though the
window was added.

To solve simply use a boolean instead of isAttachedToWindow()

Change-Id: Ib576a83cadc581683f2a5b0afc922c53b01888b7

Author: kufikugel

packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java

@@ -329,6 +329,7 @@ public class PhoneStatusBar extends BaseStatusBar implements DemoMode,
     private HeadsUpNotificationView mHeadsUpNotificationView;
     private int mHeadsUpNotificationDecay;
     private boolean mHeadsUpExpandedByDefault;
+    private boolean mHeadsUpNotificationViewAttached;
 
     // on-screen navigation buttons
     private NavigationBarView mNavigationBarView = null;
@@ -1594,10 +1595,11 @@ private WindowManager.LayoutParams getNavigationBarLayoutParams() {
     }
 
     private void addHeadsUpView() {
-        if (mHeadsUpNotificationView != null && mHeadsUpNotificationView.isAttachedToWindow()) {
+        if (mHeadsUpNotificationViewAttached) {
             return;
         }
 
+        mHeadsUpNotificationViewAttached = true;
         WindowManager.LayoutParams lp = new WindowManager.LayoutParams(
                 LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT,
                 WindowManager.LayoutParams.TYPE_STATUS_BAR_PANEL, // above the status bar!
@@ -1619,7 +1621,8 @@ private void addHeadsUpView() {
     }
 
     private void removeHeadsUpView() {
-        if (mHeadsUpNotificationView != null && mHeadsUpNotificationView.isAttachedToWindow()) {
+        if (mHeadsUpNotificationViewAttached) {
+            mHeadsUpNotificationViewAttached = false;
             mWindowManager.removeView(mHeadsUpNotificationView);
         }
     }
@@ -3933,7 +3936,7 @@ private void resetUserSetupObserver() {
 
     private void setHeadsUpVisibility(boolean vis) {
         if (DEBUG) Log.v(TAG, (vis ? "showing" : "hiding") + " heads up window");
-        if (mHeadsUpNotificationView != null && mHeadsUpNotificationView.isAttachedToWindow()) {
+        if (mHeadsUpNotificationViewAttached) {
             mHeadsUpNotificationView.setVisibility(vis ? View.VISIBLE : View.GONE);
             if (!vis) {
                 if (DEBUG) Log.d(TAG, "setting heads up entry to null");