refactor: extract should_auto_schedule helper to deduplicate guard

Extract the duplicated tournament pause/auto_start check from
schedule_next_round_robin_matches and tournament_brackets trigger
into a shared should_auto_schedule() function.

Author: Flegma

hasura/functions/tournaments/schedule_next_round_robin_matches.sql

@@ -20,7 +20,6 @@ DECLARE
     brackets_to_schedule uuid[];
     bracket_id uuid;
     bracket_row tournament_brackets%ROWTYPE;
-    _tournament_status text;
 BEGIN
     -- Get the finished bracket info
     SELECT tb.*, ts.id as stage_id, ts.type as stage_type
@@ -98,25 +97,14 @@ BEGIN
     END IF;
 
     -- Schedule all brackets that are ready (skip if tournament is paused or auto_start is off)
-    IF array_length(brackets_to_schedule, 1) > 0 THEN
-        DECLARE
-            _tournament RECORD;
-        BEGIN
-            SELECT t.status, t.auto_start INTO _tournament
-            FROM tournaments t
-            JOIN tournament_stages ts ON ts.tournament_id = t.id
-            WHERE ts.id = stage_id;
+    IF array_length(brackets_to_schedule, 1) > 0 AND should_auto_schedule(stage_id) THEN
+        FOREACH bracket_id IN ARRAY brackets_to_schedule LOOP
+            SELECT * INTO bracket_row FROM tournament_brackets WHERE id = bracket_id;
 
-            IF _tournament.status != 'Paused' AND _tournament.auto_start THEN
-                FOREACH bracket_id IN ARRAY brackets_to_schedule LOOP
-                    SELECT * INTO bracket_row FROM tournament_brackets WHERE id = bracket_id;
-
-                    IF bracket_row.match_id IS NULL THEN
-                        PERFORM schedule_tournament_match(bracket_row);
-                    END IF;
-                END LOOP;
+            IF bracket_row.match_id IS NULL THEN
+                PERFORM schedule_tournament_match(bracket_row);
             END IF;
-        END;
+        END LOOP;
     END IF;
 END;
 $$;

hasura/functions/tournaments/should_auto_schedule.sql

@@ -0,0 +1,17 @@
+CREATE OR REPLACE FUNCTION public.should_auto_schedule(
+    _tournament_stage_id uuid
+)
+RETURNS boolean
+LANGUAGE plpgsql STABLE
+AS $$
+DECLARE
+    _tournament RECORD;
+BEGIN
+    SELECT t.status, t.auto_start INTO _tournament
+    FROM tournaments t
+    JOIN tournament_stages ts ON ts.tournament_id = t.id
+    WHERE ts.id = _tournament_stage_id;
+
+    RETURN _tournament.status != 'Paused' AND _tournament.auto_start;
+END;
+$$;

hasura/triggers/tournament_brackets.sql

@@ -29,18 +29,9 @@ BEGIN
 
          raise notice 'Scheduling match for bracket %', NEW.id;
          IF NEW.tournament_team_id_1 IS NOT NULL AND NEW.tournament_team_id_2 IS NOT NULL THEN
-            DECLARE
-                _tournament RECORD;
-            BEGIN
-                SELECT t.status, t.auto_start INTO _tournament
-                FROM tournaments t
-                JOIN tournament_stages ts ON ts.tournament_id = t.id
-                WHERE ts.id = NEW.tournament_stage_id;
-
-                IF _tournament.status != 'Paused' AND _tournament.auto_start THEN
-                    PERFORM schedule_tournament_match(NEW);
-                END IF;
-            END;
+            IF should_auto_schedule(NEW.tournament_stage_id) THEN
+                PERFORM schedule_tournament_match(NEW);
+            END IF;
          END IF;
      END IF;