bug: fix tournaments being able to udpate stages while not finished / live

Author: lukepolo

hasura/functions/tournaments/can_close_tournament_registration.sql

@@ -6,7 +6,7 @@ RETURNS boolean
 LANGUAGE plpgsql STABLE
 AS $$
 BEGIN
-    IF tournament.status != 'RegistrationOpen' OR NOT tournament_has_min_teams(tournament) THEN
+    IF tournament.status != 'RegistrationOpen' THEN
         RETURN false;
     END IF;
 

hasura/functions/tournaments/get_stage_team_counts.sql

@@ -10,7 +10,7 @@ BEGIN
     WHERE tournament_id = _tournament_id AND "order" = _stage_order;
 
     -- If tournament is in Setup status, use max_teams for bracket planning
-    IF _tournament_status = 'Setup' THEN
+    IF _tournament_status != 'Live' AND _tournament_status != 'Finished' THEN
         effective_teams := stage_max_teams;
     ELSE
         IF _stage_order = 1 THEN

hasura/functions/tournaments/update_tournament_stages.sql

@@ -44,11 +44,12 @@ BEGIN
         end if;
 
         next_stage_max_teams := COALESCE((select max_teams from tournament_stages ts2 where ts2.tournament_id = _tournament_id and ts2."order" = stage."order" + 1), 1);
-        teams_per_group := CEIL(effective_teams::float / stage.groups);
+
+        RAISE NOTICE 'Stage % : effective_teams=%, next_stage_max_teams=%, groups=%', stage."order", effective_teams, next_stage_max_teams, stage.groups;
+        teams_per_group := CEIL(effective_teams::float / stage.groups); 
 
         IF stage_type = 'RoundRobin' THEN
-            RAISE NOTICE 'Stage % : RoundRobin detected, teams_per_group=%, groups=%', 
-                stage."order", teams_per_group, stage.groups;
+            RAISE NOTICE 'Stage % : RoundRobin detected', stage."order";
 
             -- For round robin, we generate all pairings
             -- Each group needs (teams_per_group * (teams_per_group - 1)) / 2 matches total

hasura/triggers/tournament_stages.sql

@@ -199,7 +199,7 @@ BEGIN
     FROM tournaments t
     WHERE t.id = NEW.tournament_id;
 
-    IF tournament_status != 'Setup' THEN
+    IF tournament_status = 'Live' OR tournament_status = 'Finished' THEN
         RAISE EXCEPTION 'Unable to modify stage since the tournament has been started';
     END IF;