bug: fix issue where discord bot job would be schedule even if not available

Author: lukepolo

src/discord-bot/discord-bot-voice-channels/discord-bot-voice-channels.service.ts

@@ -155,6 +155,10 @@ export class DiscordBotVoiceChannelsService {
           voiceChannelId,
         )) as GuildChannel;
 
+        if (!channel) {
+          return;
+        }
+
         for (const [, member] of channel.members) {
           await member.voice.setChannel(originalChannelId).catch((error) => {
             if (error.code !== 50013) {

src/discord-bot/discord-bot.module.ts

@@ -9,7 +9,7 @@ import { DiscordBotVetoService } from "./discord-bot-veto/discord-bot-veto.servi
 import { CacheModule } from "../cache/cache.module";
 import { HasuraModule } from "../hasura/hasura.module";
 import { MatchesModule } from "../matches/matches.module";
-import { BullModule, InjectQueue } from "@nestjs/bullmq";
+import { BullModule } from "@nestjs/bullmq";
 import { BullBoardModule } from "@bull-board/nestjs";
 import { BullMQAdapter } from "@bull-board/api/bullMQAdapter";
 import { DiscordBotQueues } from "./enums/DiscordBotQueues";
@@ -18,7 +18,6 @@ import { loggerFactory } from "../utilities/LoggerFactory";
 import { getQueuesProcessors } from "../utilities/QueueProcessors";
 import { DiscordBotInteractionModule } from "./interactions/discord-bot-interaction.module";
 import { RemoveArchivedThreads } from "./jobs/RemoveArchivedThreads";
-import { Queue } from "bullmq";
 
 @Module({
   imports: [
@@ -56,20 +55,4 @@ import { Queue } from "bullmq";
   ],
   controllers: [DiscordBotController],
 })
-export class DiscordBotModule {
-  constructor(@InjectQueue(DiscordBotQueues.DiscordBot) private queue: Queue) {
-    if (process.env.RUN_MIGRATIONS) {
-      return;
-    }
-
-    void queue.add(
-      RemoveArchivedThreads.name,
-      {},
-      {
-        repeat: {
-          pattern: "0 * * * *",
-        },
-      },
-    );
-  }
-}
+export class DiscordBotModule {}

src/discord-bot/discord-bot.service.ts

@@ -20,6 +20,10 @@ import { interactions } from "./interactions/interactions";
 import DiscordInteraction from "./interactions/abstracts/DiscordInteraction";
 import { Type } from "@nestjs/common";
 import MiniSearch from "minisearch";
+import { Queue } from "bullmq";
+import { DiscordBotQueues } from "./enums/DiscordBotQueues";
+import { InjectQueue } from "@nestjs/bullmq";
+import { RemoveArchivedThreads } from "./jobs/RemoveArchivedThreads";
 
 let client: Client;
 
@@ -45,6 +49,7 @@ export class DiscordBotService {
     private readonly logger: Logger,
     private readonly hasura: HasuraService,
     private readonly moduleRef: ModuleRef,
+    @InjectQueue(DiscordBotQueues.DiscordBot) private queue: Queue,
   ) {
     this.client = client;
     this.discordConfig = config.get<DiscordConfig>("discord");
@@ -144,6 +149,16 @@ export class DiscordBotService {
       return;
     }
 
+    void this.queue.add(
+      RemoveArchivedThreads.name,
+      {},
+      {
+        repeat: {
+          pattern: "0 * * * *",
+        },
+      },
+    );
+
     const rest = new REST({ version: "10" }).setToken(this.discordConfig.token);
 
     try {

src/discord-bot/jobs/RemoveArchivedThreads.ts

@@ -2,10 +2,14 @@ import { WorkerHost } from "@nestjs/bullmq";
 import { DiscordBotQueues } from "../enums/DiscordBotQueues";
 import { UseQueue } from "../../utilities/QueueProcessors";
 import { DiscordBotMessagingService } from "../discord-bot-messaging/discord-bot-messaging.service";
+import { forwardRef, Inject } from "@nestjs/common";
 
 @UseQueue("DiscordBot", DiscordBotQueues.DiscordBot)
 export class RemoveArchivedThreads extends WorkerHost {
-  constructor(private readonly messagingService: DiscordBotMessagingService) {
+  constructor(
+    @Inject(forwardRef(() => DiscordBotMessagingService))
+    private readonly messagingService: DiscordBotMessagingService,
+  ) {
     super();
   }