fix: add lobby verification lock and sockets gateway disconnect handler

Wrap matchmaking verify+setLobbyDetails+addLobbyToQueue in a Redis lock
to prevent a banned player from bypassing verification between the check
and queue addition. Add handleDisconnect lifecycle hook to SocketsGateway
and make handleConnection public for proper NestJS gateway lifecycle support.

Author: Flegma

src/matchmaking/matchmaking.gateway.ts

@@ -4,6 +4,7 @@ import { e_match_types_enum } from "generated";
 import { MatchmakeService } from "./matchmake.service";
 import { MatchmakingLobbyService } from "./matchmaking-lobby.service";
 import { RedisManagerService } from "../redis/redis-manager/redis-manager.service";
+import { CacheService } from "src/cache/cache.service";
 import { FiveStackWebSocketClient } from "src/sockets/types/FiveStackWebSocketClient";
 import {
   ConnectedSocket,
@@ -12,6 +13,7 @@ import {
   WebSocketGateway,
 } from "@nestjs/websockets";
 import { JoinQueueError } from "./utilities/joinQueueError";
+import { PlayerLobby } from "./types/PlayerLobby";
 import { HasuraService } from "src/hasura/hasura.service";
 import { isRoleAbove } from "src/utilities/isRoleAbove";
 import { e_player_roles_enum } from "generated";
@@ -29,6 +31,7 @@ export class MatchmakingGateway {
     public readonly redisManager: RedisManagerService,
     public readonly matchmakeService: MatchmakeService,
     public readonly matchmakingLobbyService: MatchmakingLobbyService,
+    private readonly cache: CacheService,
   ) {
     this.redis = this.redisManager.getConnection();
   }
@@ -122,7 +125,7 @@ export class MatchmakingGateway {
       throw new JoinQueueError("You do not have permission to join this queue");
     }
 
-    let lobby;
+    let lobby: PlayerLobby | undefined;
     const user = client.user;
 
     if (!user) {
@@ -220,16 +223,24 @@ export class MatchmakingGateway {
         throw new JoinQueueError("Unable to find Player Lobby");
       }
 
-      await this.matchmakingLobbyService.verifyLobby(lobby, user, type);
-
       try {
-        await this.matchmakingLobbyService.setLobbyDetails(
-          regions,
-          type,
-          lobby,
+        await this.cache.lock(
+          `matchmaking:verify:${lobby.id}`,
+          async () => {
+            await this.matchmakingLobbyService.verifyLobby(lobby, user, type);
+            await this.matchmakingLobbyService.setLobbyDetails(
+              regions,
+              type,
+              lobby,
+            );
+            await this.matchmakeService.addLobbyToQueue(lobby.id);
+            return true;
+          },
         );
-        await this.matchmakeService.addLobbyToQueue(lobby.id);
       } catch (error) {
+        if (error instanceof JoinQueueError) {
+          throw error;
+        }
         this.logger.error(`unable to add lobby to queue`, error);
         await this.matchmakingLobbyService.removeLobbyFromQueue(lobby.id);
         await this.matchmakingLobbyService.removeLobbyDetails(lobby.id);

src/matchmaking/matchmaking.module.ts

@@ -3,6 +3,7 @@ import { loggerFactory } from "../utilities/LoggerFactory";
 import { MatchmakingGateway } from "./matchmaking.gateway";
 import { HasuraModule } from "src/hasura/hasura.module";
 import { RedisModule } from "src/redis/redis.module";
+import { CacheModule } from "src/cache/cache.module";
 import { MatchesModule } from "src/matches/matches.module";
 import { MatchmakeService } from "./matchmake.service";
 import { MatchmakingLobbyService } from "./matchmaking-lobby.service";
@@ -19,6 +20,7 @@ import { MarkPlayerOffline } from "./jobs/MarkPlayerOffline";
   imports: [
     RedisModule,
     HasuraModule,
+    CacheModule,
     forwardRef(() => MatchesModule),
     BullModule.registerQueue({
       name: MatchmakingQueues.Matchmaking,

src/sockets/sockets.gateway.ts

@@ -22,10 +22,14 @@ export class SocketsGateway {
     await this.sockets.updateClient(client.user.steam_id, client.id);
   }
 
-  private async handleConnection(
+  public async handleConnection(
     @ConnectedSocket() client: FiveStackWebSocketClient,
     request: Request,
   ) {
     await this.sockets.setupSocket(client, request);
   }
+
+  public handleDisconnect(client: FiveStackWebSocketClient) {
+    // Cleanup is handled by client.on("close") in SocketsService.setupSocket
+  }
 }