fix: improve Discord voice channel reliability and cleanup

- Increase tournament voice cache TTL from 7 to 30 days to prevent
  channel orphaning for long-running tournaments
- Cache brand name query in getArchiveCategoryName for 1 hour to
  avoid redundant Hasura queries on every call
- Remove redundant ready room deletion in removeTournamentVoice since
  the category children loop already handles it
- Remove unreachable SingleElimination branch in getBracketRoundLabel

Author: Flegma

src/discord-bot/discord-bot-messaging/discord-bot-messaging.service.ts

@@ -207,19 +207,22 @@ export class DiscordBotMessagingService {
   }
 
   private async getArchiveCategoryName() {
-    const { settings_by_pk } = await this.hasura.query({
-      settings_by_pk: {
-        __args: {
-          name: "public.brand_name",
-        },
-        value: true,
+    const brandName = await this.cache.remember<string>(
+      "settings:brand_name",
+      async () => {
+        const { settings_by_pk } = await this.hasura.query({
+          settings_by_pk: {
+            __args: {
+              name: "public.brand_name",
+            },
+            value: true,
+          },
+        });
+        return settings_by_pk?.value || this.config.get<AppConfig>("app").name;
       },
-    });
-
-    const name =
-      settings_by_pk?.value || this.config.get<AppConfig>("app").name;
-
-    return `${name} Matches Archive`;
+      60 * 60,
+    );
+    return `${brandName} Matches Archive`;
   }
 
   public async removeArchivedThreads() {

src/discord-bot/discord-tournament-voice/discord-tournament-voice.service.ts

@@ -360,18 +360,6 @@ export class DiscordTournamentVoiceService {
     try {
       const guild = await this.bot.client.guilds.fetch(voiceCache.guildId);
 
-      try {
-        const readyRoom = await guild.channels.fetch(voiceCache.readyRoomId);
-        if (readyRoom) {
-          await readyRoom.delete();
-        }
-      } catch (error) {
-        this.logger.warn(
-          `[${tournamentId}] unable to delete ready room`,
-          error,
-        );
-      }
-
       try {
         const category = await guild.channels.fetch(voiceCache.categoryId);
         if (category && category.type === ChannelType.GuildCategory) {
@@ -413,7 +401,7 @@ export class DiscordTournamentVoiceService {
     await this.cache.put(
       this.getVoiceCacheKey(tournamentId),
       data,
-      7 * 24 * 60 * 60,
+      30 * 24 * 60 * 60,
     );
   }
 

src/discord-bot/discord-tournament-voice/utilities/getBracketRoundLabel.ts

@@ -30,9 +30,6 @@ export function getBracketRoundLabel(
     }
 
     if (totalMatchesInRound === 2) {
-      if (isLastRound && stageType === "SingleElimination") {
-        return "Final";
-      }
       return isDE ? "WB Semi-Finals" : "Semi-Finals";
     }