bug: fix showing ability to veto when should not be able to

Author: lukepolo

hasura/functions/match/lineups/is_captain.sql

@@ -14,3 +14,19 @@ BEGIN
     );
 END;
 $$;
+
+CREATE OR REPLACE FUNCTION public.is_captain_on_lineup(match_lineup public.match_lineups, hasura_session json)
+RETURNS boolean
+LANGUAGE plpgsql STABLE
+AS $$
+DECLARE
+BEGIN
+    RETURN EXISTS (
+        SELECT 1
+        FROM match_lineup_players mlp
+        WHERE mlp.match_lineup_id = match_lineup.id
+        AND mlp.steam_id = (hasura_session ->> 'x-hasura-user-id')::bigint
+        and mlp.captain = true
+    );
+END;
+$$;

hasura/functions/match/lineups/is_in_lineup.sql

@@ -3,11 +3,6 @@ CREATE OR REPLACE FUNCTION public.is_in_lineup(match public.matches, hasura_sess
     AS $$
 DECLARE
 BEGIN
-
-    IF(hasura_session ->> 'x-hasura-role' = 'admin') THEN
-        RETURN true;
-    END IF;
-
     RETURN EXISTS (
         SELECT 1
         FROM match_lineups ml

hasura/functions/match/map-veto/can_pick_map_veto.sql

@@ -3,7 +3,7 @@ CREATE OR REPLACE FUNCTION public.can_pick_map_veto(match_lineup public.match_li
     AS $$
 DECLARE
 BEGIN
-      IF lineup_is_picking_map_veto(match_lineup) AND is_on_lineup(match_lineup, hasura_session) THEN
+      IF lineup_is_picking_map_veto(match_lineup) AND is_captain_on_lineup(match_lineup, hasura_session) THEN
         return true;
       END IF;
 

hasura/functions/match/region-veto/can_pick_region_veto.sql

@@ -3,7 +3,7 @@ CREATE OR REPLACE FUNCTION public.can_pick_region_veto(match_lineup public.match
     AS $$
 DECLARE
 BEGIN
-      IF lineup_is_picking_region_veto(match_lineup) AND is_on_lineup(match_lineup, hasura_session) THEN
+      IF lineup_is_picking_region_veto(match_lineup) AND is_captain_on_lineup(match_lineup, hasura_session) THEN
         return true;
       END IF;