Merge bitcoindevkit#382: refactor(wallet)!: Remove unused ApplyBlockError

20fea22 refactor: remove unused ApplyBlockError (thunderbiscuit)

Pull request description:

  This was caught by ValuedMammal here: bitcoindevkit#378 (comment)

  ### Description

  This PR removes an unused error.

  An alternative could be to repurpose the type to be used as the error for the `apply_block*` methods, as it seems to be adequately named to go along with `Wallet::apply_block`.

  ### Changelog notice

  - Removed `ApplyBlockError` from the public API

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `just p` before pushing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  luisschwab:
    ACK 20fea22
  evanlinjin:
    ACK 20fea22
  110CodingP:
    ACK [20fea22](bitcoindevkit@20fea22)

Tree-SHA512: 964ca874cce8778a7ca72a9bcc438894a9a422fd688ba9fbf61e580357e322dd05f17ee0c6ebedb746597342b6983d150120a32ce267418b7622f7960255ff63

Author: ValuedMammal

src/wallet/error.rs

@@ -20,7 +20,6 @@ use alloc::{
     string::{String, ToString},
 };
 use bitcoin::{absolute, psbt, Amount, BlockHash, Network, OutPoint, Sequence, Txid};
-use chain::local_chain::CannotConnectError;
 use core::fmt;
 
 /// The error type when loading a [`Wallet`] from a [`ChangeSet`].
@@ -128,38 +127,6 @@ impl From<LoadMismatch> for LoadError {
     }
 }
 
-/// An error that may occur when applying a block to [`Wallet`].
-#[derive(Debug)]
-pub enum ApplyBlockError {
-    /// Occurs when the update chain cannot connect with original chain.
-    CannotConnect(CannotConnectError),
-    /// Occurs when the `connected_to` hash does not match the hash derived from `block`.
-    UnexpectedConnectedToHash {
-        /// Block hash of `connected_to`.
-        connected_to_hash: BlockHash,
-        /// Expected block hash of `connected_to`, as derived from `block`.
-        expected_hash: BlockHash,
-    },
-}
-
-impl fmt::Display for ApplyBlockError {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        match self {
-            ApplyBlockError::CannotConnect(err) => err.fmt(f),
-            ApplyBlockError::UnexpectedConnectedToHash {
-                expected_hash: block_hash,
-                connected_to_hash: checkpoint_hash,
-            } => write!(
-                f,
-                "`connected_to` hash {checkpoint_hash} differs from the expected hash {block_hash} (which is derived from `block`)"
-            ),
-        }
-    }
-}
-
-#[cfg(feature = "std")]
-impl std::error::Error for ApplyBlockError {}
-
 /// Errors returned by miniscript when updating inconsistent PSBTs
 #[derive(Debug, Clone)]
 pub enum MiniscriptPsbtError {

src/wallet/mod.rs

@@ -80,7 +80,7 @@ use crate::wallet::{
 // re-exports
 pub use bdk_chain::Balance;
 pub use changeset::ChangeSet;
-pub use error::{ApplyBlockError, LoadError, LoadMismatch};
+pub use error::{LoadError, LoadMismatch};
 pub use event::*;
 pub use params::*;
 pub use persisted::*;